feat: add configurable default theme option#16
Merged
Conversation
Owner
|
Hey @gogongxt, clean PR. The placeholder pattern is right and the Could you rename
If you push that rename plus a one-line README touch-up, I'll merge. Closes #19. |
This was referenced May 24, 2026
Contributor
Author
|
Done. |
Allow users to set the initial preview theme ("dark" or "light") via
the `theme` config option, defaulting to "dark" for backwards
compatibility. Previously the theme was hardcoded to dark in both
the HTML template and JavaScript.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
selimacerbas
force-pushed
the
feat/theme-config
branch
from
7d63b42 to
8d6ce04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
themeconfig option ("dark"or"light") to set the initial preview page theme, defaulting to"dark"for backwards compatibility"dark"in both the HTML template (data-theme) and JavaScript (currentTheme/applyTheme('dark'))__PLACEHOLDER__+ gsub pattern asbottom_paddingChanges
assets/index.html: Replace hardcodeddata-theme="dark"withdata-theme="__THEME__", read initial theme fromdataset.themein JS, and usecurrentThemein boot instead of hardcoded'dark'lua/markdown_preview/init.lua: Addtheme = "dark"to config, add__THEME__gsub inwrite_index()README.md: Documentthemeoption in Quick start and Configuration sectionsUsage